get_types: prevent mess with default parameters

1 files changed, 16 insertions, 4 deletions

diff --git a/ishtar_common/models.py b/ishtar_common/models.py
index bb19b0913..c554a0ee2 100644
--- a/ishtar_common/models.py
+++ b/ishtar_common/models.py
@@ -736,8 +736,12 @@ class GeneralType(Cached, models.Model):
         return new_vals
 
     @classmethod
-    def get_types(cls, dct={}, instances=False, exclude=[], empty_first=True,
-                  default=None, initial=None, force=False):
+    def get_types(cls, dct=None, instances=False, exclude=None,
+                  empty_first=True, default=None, initial=None, force=False):
+        if not dct:
+            dct = {}
+        if not exclude:
+            exclude = []
         types = []
         if not instances and empty_first and not default:
             types = [('', '--')]
@@ -750,8 +754,12 @@ class GeneralType(Cached, models.Model):
         return types
 
     @classmethod
-    def _pre_get_types(cls, dct={}, instances=False, exclude=[],
+    def _pre_get_types(cls, dct=None, instances=False, exclude=None,
                        default=None, force=False):
+        if not dct:
+            dct = {}
+        if not exclude:
+            exclude = []
         # cache
         cache_key = None
         if not instances:
@@ -901,8 +909,12 @@ class GeneralType(Cached, models.Model):
         return lst
 
     @classmethod
-    def _get_parent_types(cls, dct={}, instances=False, exclude=[],
+    def _get_parent_types(cls, dct=None, instances=False, exclude=None,
                           default=None):
+        if not dct:
+            dct = {}
+        if not exclude:
+            exclude = []
         dct['available'] = True
         dct['parent'] = None
         items = cls.objects.filter(**dct)