ForeignKey: SET_NULL fix

1 files changed, 15 insertions, 5 deletions

diff --git a/ishtar_common/models.py b/ishtar_common/models.py
index 7f5857037..a37c1f6bc 100644
--- a/ishtar_common/models.py
+++ b/ishtar_common/models.py
@@ -953,6 +953,7 @@ class GeneralType(Cached, models.Model):
 
 class HierarchicalType(GeneralType):
     parent = models.ForeignKey('self', blank=True, null=True,
+                               on_delete=models.SET_NULL,
                                verbose_name=_(u"Parent"))
 
     class Meta:
@@ -1165,7 +1166,8 @@ class JsonDataField(models.Model):
     order = models.IntegerField(_(u"Order"), default=10)
     search_index = models.BooleanField(_(u"Use in search indexes"),
                                        default=False)
-    section = models.ForeignKey(JsonDataSection, blank=True, null=True)
+    section = models.ForeignKey(JsonDataSection, blank=True, null=True,
+                                on_delete=models.SET_NULL)
     custom_forms = models.ManyToManyField(
         "CustomForm", blank=True, through="CustomFormJsonField")
 
@@ -2732,8 +2734,10 @@ class State(models.Model):
 class Department(models.Model):
     label = models.CharField(_(u"Label"), max_length=30)
     number = models.CharField(_(u"Number"), unique=True, max_length=3)
-    state = models.ForeignKey('State', verbose_name=_(u"State"), blank=True,
-                              null=True)
+    state = models.ForeignKey(
+        'State', verbose_name=_(u"State"), blank=True, null=True,
+        on_delete=models.SET_NULL,
+    )
     objects = NumberManager()
 
     class Meta:
@@ -3127,6 +3131,7 @@ class Person(Address, Merge, OwnPerms, ValueGetter):
     old_title = models.CharField(_(u"Title"), max_length=100, choices=TYPE,
                                  blank=True, null=True)
     title = models.ForeignKey(TitleType, verbose_name=_(u"Title"),
+                              on_delete=models.SET_NULL,
                               blank=True, null=True)
     salutation = models.CharField(_(u"Salutation"), max_length=200,
                                   blank=True, null=True)
@@ -3616,6 +3621,7 @@ class Basket(FullSearch, OwnPerms):
     comment = models.TextField(_(u"Comment"), blank=True, null=True)
     user = models.ForeignKey(
         IshtarUser, blank=True, null=True, related_name='%(class)ss',
+        on_delete=models.SET_NULL,
         verbose_name=_(u"Owner"))
     available = models.BooleanField(_(u"Available"), default=True)
     shared_with = models.ManyToManyField(
@@ -3974,13 +3980,16 @@ class Document(BaseHistorizedItem, OwnPerms, ImageModel):
     internal_reference = models.TextField(_(u"Internal ref."), null=True,
                                           blank=True)
     source_type = models.ForeignKey(SourceType, verbose_name=_(u"Type"),
+                                    on_delete=models.SET_NULL,
                                     null=True, blank=True)
     licenses = models.ManyToManyField(LicenseType, verbose_name=_(u"License"),
                                       blank=True)
     support_type = models.ForeignKey(SupportType, verbose_name=_(u"Support"),
+                                     on_delete=models.SET_NULL,
                                      blank=True, null=True, )
     format_type = models.ForeignKey(Format, verbose_name=_(u"Format"),
-                                    blank=True, null=True, )
+                                    on_delete=models.SET_NULL,
+                                    blank=True, null=True)
     scale = models.CharField(_(u"Scale"), max_length=30, null=True,
                              blank=True)
     authors = models.ManyToManyField(Author, verbose_name=_(u"Authors"),
@@ -4313,7 +4322,8 @@ class Town(Imported, models.Model):
     numero_insee = models.CharField(u"Code commune (numéro INSEE)",
                                     max_length=120)
     departement = models.ForeignKey(
-        Department, verbose_name=_(u"Department"), null=True, blank=True)
+        Department, verbose_name=_(u"Department"),
+        on_delete=models.SET_NULL, null=True, blank=True)
     year = models.IntegerField(
         _("Year of creation"), null=True, blank=True,
         help_text=_(u"Filling this field is relevant to distinguish old towns "