Extra security to prevent recursion on bulk update

1 files changed, 23 insertions, 0 deletions

diff --git a/ishtar_common/models.py b/ishtar_common/models.py
index 6c83c8bfb..2475cd289 100644
--- a/ishtar_common/models.py
+++ b/ishtar_common/models.py
@@ -31,6 +31,7 @@ import os
 import re
 import shutil
 import tempfile
+import time
 import unicodecsv
 import zipfile
 
@@ -861,6 +862,28 @@ class HistoryError(Exception):
 PRIVATE_FIELDS = ('id', 'history_modifier', 'order')
 
 
+class BulkUpdatedItem(object):
+    @classmethod
+    def bulk_recursion(cls, transaction_id, extra_args):
+        """
+        Prevent infinite recursion. Should not happen but wrong manipulation
+        in the database or messy imports can generate circular relations
+
+        :param transaction_id: current transaction ID (unix time) - if null
+        a transaction ID is generated
+        :param extra_args: arguments dealing with
+        :return: (transaction ID, is a recursion)
+        """
+        if not transaction_id:
+            transaction_id = unicode(time.time())
+        args = ['cached_label_bulk_update', transaction_id] + extra_args
+        key, val = get_cache(cls, args)
+        if val:
+            return transaction_id, True
+        cache.set(key, 1, settings.CACHE_SMALLTIMEOUT)
+        return transaction_id, False
+
+
 class BaseHistorizedItem(Imported):
     IS_BASKET = False
     history_modifier = models.ForeignKey(