Migration to Django 2.2 - missing on_delete - django.urls import reverse

1 files changed, 19 insertions, 6 deletions

diff --git a/archaeological_finds/models_treatments.py b/archaeological_finds/models_treatments.py
index 5d4597b19..7cbf0334a 100644
--- a/archaeological_finds/models_treatments.py
+++ b/archaeological_finds/models_treatments.py
@@ -22,10 +22,10 @@ import datetime
 from django.conf import settings
 from django.contrib.gis.db import models
 from django.contrib.postgres.indexes import GinIndex
-from django.core.urlresolvers import reverse
 from django.db.models import Max, Q
 from django.db.models.signals import post_save, post_delete, pre_delete, m2m_changed
 from django.template.defaultfilters import slugify
+from django.urls import reverse
 from ishtar_common.utils import ugettext_lazy as _, pgettext_lazy
 
 from archaeological_finds.models_finds import Find, FindBasket, TreatmentType
@@ -208,7 +208,10 @@ class Treatment(
         TreatmentType, verbose_name=_("Treatment type")
     )
     treatment_state = models.ForeignKey(
-        TreatmentState, verbose_name=_("State"), default=TreatmentState.get_default
+        TreatmentState,
+        verbose_name=_("State"),
+        default=TreatmentState.get_default,
+        on_delete=models.PROTECT,
     )
     executed = models.BooleanField(_("Treatment have been executed"), default=False)
     location = models.ForeignKey(
@@ -728,10 +731,16 @@ for attr in Treatment.HISTORICAL_M2M:
 
 class AbsFindTreatments(models.Model):
     find = models.ForeignKey(
-        Find, verbose_name=_("Find"), related_name="%(class)s_related"
+        Find,
+        verbose_name=_("Find"),
+        related_name="%(class)s_related",
+        on_delete=models.DO_NOTHING,
     )
     treatment = models.OneToOneField(
-        Treatment, verbose_name=_("Treatment"), primary_key=True
+        Treatment,
+        verbose_name=_("Treatment"),
+        primary_key=True,
+        on_delete=models.DO_NOTHING,
     )
     # primary_key is set to prevent django to ask for an id column
     # treatment is not a real primary key
@@ -981,7 +990,9 @@ class FindTreatments(AbsFindTreatments):
 
 
 class TreatmentFileType(GeneralType):
-    treatment_type = models.ForeignKey(TreatmentType, blank=True, null=True)
+    treatment_type = models.ForeignKey(
+        TreatmentType, blank=True, null=True, on_delete=models.SET_NULL
+    )
 
     class Meta:
         verbose_name = _("Treatment request type")
@@ -1091,7 +1102,9 @@ class TreatmentFile(
     )
     name = models.TextField(_("Name"), blank=True, default="")
     type = models.ForeignKey(
-        TreatmentFileType, verbose_name=_("Treatment request type")
+        TreatmentFileType,
+        verbose_name=_("Treatment request type"),
+        on_delete=models.PROTECT,
     )
     in_charge = models.ForeignKey(
         Person,