Prevent incoherent RelationType

* check that no relation type with symmetrical=True and an inverse relation are
  set
* after saving check that theinverse_relation of the inverse_relation
  point to the saved object
* test update

2 files changed, 109 insertions, 0 deletions

diff --git a/archaeological_context_records/models.py b/archaeological_context_records/models.py
index a8c6a1dcc..9a4fa7880 100644
--- a/archaeological_context_records/models.py
+++ b/archaeological_context_records/models.py
@@ -19,6 +19,7 @@
 
 from django.conf import settings
 from django.contrib.gis.db import models
+from django.core.exceptions import ValidationError
 from django.core.urlresolvers import reverse
 from django.utils.translation import ugettext_lazy as _, ugettext, pgettext
 
@@ -252,6 +253,24 @@ class RelationType(GeneralType):
         verbose_name_plural = _(u"Relation types")
         ordering = ('order',)
 
+    def clean(self):
+        # cannot have symmetrical and an inverse_relation
+        if self.symmetrical and self.inverse_relation:
+            raise ValidationError(
+                        _(u"Cannot have symmetrical and an inverse_relation"))
+
+    def save(self, *args, **kwargs):
+        obj = super(RelationType, self).save(*args, **kwargs)
+        # after saving check that the inverse_relation of the inverse_relation
+        # point to the saved object
+        if self.inverse_relation \
+           and (not self.inverse_relation.inverse_relation
+                or self.inverse_relation.inverse_relation != self):
+            self.inverse_relation.inverse_relation = self
+            self.inverse_relation.symmetrical = False
+            self.inverse_relation.save()
+        return obj
+
 class RecordRelations(models.Model):
     left_record = models.ForeignKey(ContextRecord,
                                     related_name='left_relations')
diff --git a/archaeological_context_records/tests.py b/archaeological_context_records/tests.py
new file mode 100644
index 000000000..2d144de3a
--- /dev/null
+++ b/archaeological_context_records/tests.py
@@ -0,0 +1,90 @@
+#!/usr/bin/env python
+# -*- coding: utf-8 -*-
+# Copyright (C) 2015 Étienne Loks  <etienne.loks_AT_peacefrogsDOTnet>
+
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License as
+# published by the Free Software Foundation, either version 3 of the
+# License, or (at your option) any later version.
+
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Affero General Public License for more details.
+
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+# See the file COPYING for details.
+
+"""
+Unit tests
+"""
+import json
+
+from django.conf import settings
+from django.core.exceptions import ValidationError
+from django.test import TestCase
+
+from archaeological_operations.tests import OperationInitTest
+from archaeological_operations.models import Parcel
+from archaeological_context_records import models
+
+
+class ContextRecordInit(OperationInitTest):
+
+    def create_context_record(self, user=None, data={}):
+        if not getattr(self, 'context_records', None):
+            self.context_records = []
+
+        default = {'label':"Context record"}
+        if not data.get('operation'):
+            data['operation'] = self.get_default_operation()
+        if not data.get('parcel'):
+            data['parcel'] = self.get_default_parcel()
+        if not data.get('user'):
+            data['user'] = self.get_default_user()
+
+        default.update(data)
+        context_records.append(models.ContextRecord.create(**default))
+        return context_records
+
+    def get_default_context_record(self):
+        return self.create_context_record()[0]
+
+class RecordRelationsTest(TestCase, ContextRecordInit):
+    fixtures = [settings.ROOT_PATH +
+                '../fixtures/initial_data.json',
+                settings.ROOT_PATH +
+                '../ishtar_common/fixtures/initial_data.json',
+                settings.ROOT_PATH +
+                '../archaeological_files/fixtures/initial_data.json',
+                settings.ROOT_PATH +
+                '../archaeological_operations/fixtures/initial_data-fr.json']
+    model = models.ContextRecord
+
+    def setUp(self):
+        # two different context record
+        print(1333)
+        self.create_context_record({"label":u"CR 1"})
+        print(1444)
+        self.create_context_record({"label":u"CR 2"})
+        print(15555)
+
+    def testRelations(self):
+        print(1)
+        sym_rel = models.RelationType.objects.create(symmetrical=True)
+        print(12)
+        rel_1 = models.RelationType.objects.create(symmetrical=False)
+        print(13)
+        rel_2 = models.RelationType.objects.create(symmetrical=False,
+                                    inverse_relation=rel_1)
+        print(14)
+        # cannot have symmetrical and an inverse_relation
+        with self.assertRaises(ValidationError):
+            rel_3 = models.RelationType.objects.create(symmetrical=True,
+                                    inverse_relation=rel_1)
+        print(15)
+        # auto fill inverse relations
+        self.assertEqual(rel_1.inverse_relation, rel_2)
+