diff options
| author | Étienne Loks <etienne.loks@iggdrasil.net> | 2019-05-28 14:52:05 +0200 |
|---|---|---|
| committer | Étienne Loks <etienne.loks@iggdrasil.net> | 2019-06-17 13:21:28 +0200 |
| commit | bf894073124b8c86f9d11f14f61962781e436fcd (patch) | |
| tree | 3b15dbc3e4bb9071ab9e2cf18839150953b9f0e2 | |
| parent | 907c4f5dafe3b2083ccb71ed1aacaf99bab63a59 (diff) | |
| download | Ishtar-bf894073124b8c86f9d11f14f61962781e436fcd.tar.bz2 Ishtar-bf894073124b8c86f9d11f14f61962781e436fcd.zip | |
get_types: prevent mess with default parameters
| -rw-r--r-- | ishtar_common/models.py | 20 |
1 files changed, 16 insertions, 4 deletions
diff --git a/ishtar_common/models.py b/ishtar_common/models.py index bb19b0913..c554a0ee2 100644 --- a/ishtar_common/models.py +++ b/ishtar_common/models.py @@ -736,8 +736,12 @@ class GeneralType(Cached, models.Model): return new_vals @classmethod - def get_types(cls, dct={}, instances=False, exclude=[], empty_first=True, - default=None, initial=None, force=False): + def get_types(cls, dct=None, instances=False, exclude=None, + empty_first=True, default=None, initial=None, force=False): + if not dct: + dct = {} + if not exclude: + exclude = [] types = [] if not instances and empty_first and not default: types = [('', '--')] @@ -750,8 +754,12 @@ class GeneralType(Cached, models.Model): return types @classmethod - def _pre_get_types(cls, dct={}, instances=False, exclude=[], + def _pre_get_types(cls, dct=None, instances=False, exclude=None, default=None, force=False): + if not dct: + dct = {} + if not exclude: + exclude = [] # cache cache_key = None if not instances: @@ -901,8 +909,12 @@ class GeneralType(Cached, models.Model): return lst @classmethod - def _get_parent_types(cls, dct={}, instances=False, exclude=[], + def _get_parent_types(cls, dct=None, instances=False, exclude=None, default=None): + if not dct: + dct = {} + if not exclude: + exclude = [] dct['available'] = True dct['parent'] = None items = cls.objects.filter(**dct) |