From 367059ddef14a495e277f68ceaf3455c092f839d Mon Sep 17 00:00:00 2001 From: Étienne Loks Date: Tue, 11 Apr 2023 12:27:23 +0200 Subject: bandit checker: mark false security issues - fix security issues (low severity) --- ishtar_common/rest.py | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) (limited to 'ishtar_common/rest.py') diff --git a/ishtar_common/rest.py b/ishtar_common/rest.py index e489e5f80..08fc2dc36 100644 --- a/ishtar_common/rest.py +++ b/ishtar_common/rest.py @@ -32,7 +32,8 @@ class SearchAPIView(APIView): permission_classes = (permissions.IsAuthenticated, IpModelPermission) def __init__(self, **kwargs): - assert self.model is not None + if not self.model: + raise NotImplementedError("model attribute is not defined") super(SearchAPIView, self).__init__(**kwargs) def search_model_query(self, request): @@ -99,9 +100,10 @@ class FacetAPIView(APIView): select_forms = [] def __init__(self, **kwargs): - assert self.models - assert self.select_forms - assert len(self.models) == len(self.select_forms) + if not self.models or not self.select_forms: + raise NotImplementedError("models or select_forms attribute is not defined") + if len(self.models) != len(self.select_forms): + raise NotImplementedError("len of models and select_forms must be equals") super().__init__(**kwargs) def get(self, request, format=None): @@ -223,7 +225,8 @@ class GetAPIView(generics.RetrieveAPIView): model = None def __init__(self, **kwargs): - assert self.model is not None + if self.model is None: + raise NotImplementedError("model attribute is not defined") super().__init__(**kwargs) def search_model_query(self, request): -- cgit v1.2.3