From e4df561285b6fbda6b57477b7fa59ca9168e83e7 Mon Sep 17 00:00:00 2001 From: Étienne Loks Date: Tue, 30 Aug 2022 17:49:23 +0200 Subject: Fix many count search such has "has-finds" (refs #5425) --- archaeological_warehouse/forms.py | 3 ++- archaeological_warehouse/models.py | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) (limited to 'archaeological_warehouse') diff --git a/archaeological_warehouse/forms.py b/archaeological_warehouse/forms.py index 57fc31f4f..e942878a7 100644 --- a/archaeological_warehouse/forms.py +++ b/archaeological_warehouse/forms.py @@ -512,7 +512,8 @@ class ContainerSelect(DocumentItemSelect): old_reference = forms.CharField(label=_("Old reference")) comment = forms.CharField(label=_("Comment")) contain_containers = forms.NullBooleanField(label=_("Contain containers")) - empty = forms.NullBooleanField(label=_("Currently empty")) + ## to be rethink: the current request if it has got finds directly inside + # empty = forms.NullBooleanField(label=_("Currently empty")) is_stationary = forms.NullBooleanField(label=_("Is stationary")) parent = forms.IntegerField( label=_("Parent container"), diff --git a/archaeological_warehouse/models.py b/archaeological_warehouse/models.py index 2e2aae732..9a8bc86c2 100644 --- a/archaeological_warehouse/models.py +++ b/archaeological_warehouse/models.py @@ -1004,7 +1004,8 @@ class Container( pgettext_lazy("key for text search", "find-description"), "finds__description__iexact", ), - "empty": SearchAltName(pgettext_lazy("key for text search", "empty"), "finds"), + "empty": SearchAltName(pgettext_lazy("key for text search", "empty"), + "finds__isnull"), "parent": SearchAltName( pgettext_lazy("key for text search", "parent-container"), "parent__cached_label__iexact", @@ -1025,7 +1026,7 @@ class Container( "documents__associated_url__isnull", ] BOOL_FIELDS = LightHistorizedItem.BOOL_FIELDS + ["container_type__stationary"] - REVERSED_MANY_COUNTED_FIELDS = ["finds", "finds_ref"] + REVERSED_MANY_COUNTED_FIELDS = ["finds__isnull", "finds_ref"] ALT_NAMES.update(LightHistorizedItem.ALT_NAMES) ALT_NAMES.update(DocumentItem.ALT_NAMES) -- cgit v1.2.3